spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ArtRand <...@git.apache.org>
Subject [GitHub] spark pull request #18837: [Spark-20812][Mesos] Add secrets support to the d...
Date Fri, 11 Aug 2017 00:04:26 GMT
Github user ArtRand commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18837#discussion_r132597784
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
    @@ -529,18 +570,120 @@ private[spark] class MesosClusterScheduler(
     
         val appName = desc.conf.get("spark.app.name")
     
    +    val driverLabels = MesosProtoUtils.mesosLabels(desc.conf.get(config.DRIVER_LABELS)
    +      .getOrElse(""))
    +
         TaskInfo.newBuilder()
           .setTaskId(taskId)
           .setName(s"Driver for ${appName}")
           .setSlaveId(offer.offer.getSlaveId)
           .setCommand(buildDriverCommand(desc))
    +      .setContainer(getContainerInfo(desc))
           .addAllResources(cpuResourcesToUse.asJava)
           .addAllResources(memResourcesToUse.asJava)
    -      .setLabels(MesosProtoUtils.mesosLabels(desc.conf.get(config.DRIVER_LABELS).getOrElse("")))
    -      .setContainer(MesosSchedulerBackendUtil.containerInfo(desc.conf))
    +      .setLabels(driverLabels)
           .build
       }
     
    +  private def getContainerInfo(desc: MesosDriverDescription): ContainerInfo.Builder =
{
    +    val containerInfo = MesosSchedulerBackendUtil.containerInfo(desc.conf)
    +
    +    getSecretVolume(desc).foreach { volume =>
    +      logInfo(s"Setting secret name=${volume.getSource.getSecret.getReference.getName}
" +
    --- End diff --
    
    Good catch, I changed this to be conditioned on the secret being a `REFERENCE` type. (You
probably don't want the content of your secret printed to the logs with `VALUE` type. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message