spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #18820: [SPARK-14932][SQL] Allow DataFrame.replace() to r...
Date Mon, 07 Aug 2017 04:15:42 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18820#discussion_r131570031
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
    @@ -314,6 +316,7 @@ final class DataFrameNaFunctions private[sql](df: DataFrame) {
        * (Scala-specific) Replaces values matching keys in `replacement` map.
        * Key and value of `replacement` map must have the same type, and
        * can only be doubles, strings or booleans.
    +   * `replacement` map value can have null.
    --- End diff --
    
    Do not put it here. It should be put in @parm. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message