spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jiangxb1987 <...@git.apache.org>
Subject [GitHub] spark pull request #18801: SPARK-10878 Fix race condition when multiple clie...
Date Sun, 06 Aug 2017 15:40:56 GMT
Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18801#discussion_r131545611
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -1216,7 +1216,36 @@ private[spark] object SparkSubmitUtils {
     
       /** A nice function to use in tests as well. Values are dummy strings. */
       def getModuleDescriptor: DefaultModuleDescriptor = DefaultModuleDescriptor.newDefaultInstance(
    -    ModuleRevisionId.newInstance("org.apache.spark", "spark-submit-parent", "1.0"))
    +    // Include timestamp in module name, so multiple clients resolving maven coordinates
at the
    +    // same time do not modify the same resolution file concurrently.
    +    ModuleRevisionId.newInstance("org.apache.spark",
    +      "spark-submit-parent-" + System.currentTimeMillis().toString,
    --- End diff --
    
    nit: `"spark-submit-parent-" + System.currentTimeMillis().toString` -> `s"spark-submit-parent-${System.currentTimeMillis}"`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message