spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <>
Subject [GitHub] spark pull request #12646: [SPARK-14878][SQL] Trim characters string functio...
Date Sun, 06 Aug 2017 04:19:59 GMT
Github user gatorsmile commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
    @@ -1121,6 +1125,30 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef]
with Logging
    +   * Create a function name LTRIM for TRIM(Leading), RTRIM for TRIM(Trailing), TRIM for
    +   * otherwise, return the original function identifier.
    +   */
    +  private def replaceTrimFunction(funcID: FunctionIdentifier, ctx: FunctionCallContext)
    --- End diff --
    move this function into `visitFunctionCall `

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message