spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request #18742: [Spark-21542][ML][Python]Python persistence helpe...
Date Wed, 02 Aug 2017 21:30:23 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18742#discussion_r131000859
  
    --- Diff: python/pyspark/ml/util.py ---
    @@ -61,32 +66,82 @@ def _randomUID(cls):
     
     
     @inherit_doc
    -class MLWriter(object):
    +class BaseReadWrite(object):
    +    """
    +    Base class for MLWriter and MLReader. Stores information about the SparkContext
    +    and SparkSession.
    +
    +    .. versionadded:: 2.3.0
    +    """
    +
    +    def __init__(self):
    +        self.sparkSession = None
    +
    +    def context(self, sqlContext):
    +        """
    +        Sets the SQL context to use for saving.
    +
    +        .. note:: Deprecated in 2.1 and will be removed in 3.0, use session instead.
    +        """
    +        # raise NotImplementedError("MLWriter is not yet implemented for type: %s" %
type(self))
    +        self.sparkSession = sqlContext.sparkSession
    +        return self
    +
    +    def session(self, sparkSession):
    +        """Sets the Spark Session to use for saving."""
    --- End diff --
    
    Copy doc from Scala; no need to rewrite it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message