spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #18804: [SPARK-21599][SQL] Collecting column statistics f...
Date Wed, 02 Aug 2017 07:25:44 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18804#discussion_r130803491
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
---
    @@ -642,8 +642,13 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf:
Configurat
           if (stats.get.rowCount.isDefined) {
             statsProperties += STATISTICS_NUM_ROWS -> stats.get.rowCount.get.toString()
           }
    +
    +      // For datasource tables and hive serde tables created by spark 2.1 or higher,
    --- End diff --
    
    IIUC, here I think we should test when the schema read by `getRawTable` (i.e., `rawTable`)
is different than the schema stored in table properties. 
    
    Previously because two copies of schema are different, you will get the `NoSuchElement`
too. That's why we should call `restoreTableMetadata` here for hive serde tables.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message