spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MrBago <...@git.apache.org>
Subject [GitHub] spark pull request #17373: [SPARK-12664] Expose probability in mlp model
Date Tue, 01 Aug 2017 22:46:07 GMT
Github user MrBago commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17373#discussion_r130747996
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala
---
    @@ -82,6 +83,23 @@ class MultilayerPerceptronClassifierSuite
         }
       }
     
    +  test("test model probability") {
    +    val layers = Array[Int](2, 5, 2)
    +    val trainer = new MultilayerPerceptronClassifier()
    +      .setLayers(layers)
    +      .setBlockSize(1)
    +      .setSeed(123L)
    +      .setMaxIter(100)
    +      .setSolver("l-bfgs")
    +    val model = trainer.fit(dataset)
    +    model.setProbabilityCol("probability")
    +    val result = model.transform(dataset)
    +    val features2prob = udf { features: Vector => model.mlpModel.predict(features)
}
    +    val cmpVec = udf { (v1: Vector, v2: Vector) => v1 ~== v2 relTol 1e-3 }
    +    assert(result.select(cmpVec(features2prob(col("features")), col("probability")))
    +      .rdd.map(_.getBoolean(0)).reduce(_ && _))
    +  }
    +
    --- End diff --
    
    I think we should include a stronger test for this. I did a quick search and couldn't
find a strong test for `mlpModel.predict`, it might be good to add one. Also, I believe this
xor dataset only produces probability predictions ~equal to 0 or 1.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message