Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: cloud-fan <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-16422-spark@git.apache.org>
In-Reply-To: <git-pr-16422-spark@git.apache.org>
Subject: [GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...
Content-Type: text/plain
Message-Id: <20170710075609.55E93E0A98@git1-us-west.apache.org>
Date: Mon, 10 Jul 2017 07:56:09 +0000 (UTC)
archived-at: Mon, 10 Jul 2017 07:56:11 -0000

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16422#discussion_r126355022
  
    --- Diff: sql/core/src/test/resources/sql-tests/results/describe-table-column.sql.out ---
    @@ -0,0 +1,133 @@
    +-- Automatically generated by SQLQueryTestSuite
    +-- Number of queries: 15
    +
    +
    +-- !query 0
    +CREATE TEMPORARY VIEW desc_col_temp_table (key int COMMENT 'column_comment') USING PARQUET
    +-- !query 0 schema
    +struct<>
    +-- !query 0 output
    +
    +
    +
    +-- !query 1
    +DESC desc_col_temp_table key
    +-- !query 1 schema
    +struct<col_name:string,data_type:string,comment:string>
    +-- !query 1 output
    +col_name 	data_type 	comment        	
    +key      	int       	column_comment
    +
    +
    +-- !query 2
    +DESC EXTENDED desc_col_temp_table key
    +-- !query 2 schema
    +struct<col_name:string,data_type:string,min:string,max:string,num_nulls:string,distinct_count:string,avg_col_len:string,max_col_len:string,comment:string>
    +-- !query 2 output
    +col_name 	data_type 	min  	max  	num_nulls 	distinct_count 	avg_col_len 	max_col_len 	comment        	
    --- End diff --
    
    ok then we need to decide if we wanna diverge with hive here, cc @gatorsmile 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org