Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: jkbradley <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18428-spark@git.apache.org>
In-Reply-To: <git-pr-18428-spark@git.apache.org>
Subject: [GitHub] spark pull request #18428: [Spark-21221][ML] CrossValidator and TrainValidat...
Content-Type: text/plain
Message-Id: <20170702073537.91B8FF3253@git1-us-west.apache.org>
Date: Sun,  2 Jul 2017 07:35:37 +0000 (UTC)
archived-at: Sun, 02 Jul 2017 07:35:40 -0000

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18428#discussion_r125175867
  
    --- Diff: python/pyspark/ml/classification.py ---
    @@ -1630,8 +1614,52 @@ def _to_java(self):
             _java_obj.setPredictionCol(self.getPredictionCol())
             return _java_obj
     
    +    def _make_java_param_pair(self, param, value):
    +        """
    +        Makes a Java parm pair.
    --- End diff --
    
    correct typo: parm -> param (and in original please)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org