spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark issue #18664: [SPARK-21375][PYSPARK][SQL][WIP] Add Date and Timestamp ...
Date Mon, 31 Jul 2017 18:13:19 GMT
Github user BryanCutler commented on the issue:

    https://github.com/apache/spark/pull/18664
  
    The root of the problem is that `SESSION_LOCAL_TIMEZONE` is not used in `toInternal`/`fromInternal`
in the timestamp type [here](https://github.com/BryanCutler/spark/blob/master/python/pyspark/sql/types.py#L179).
 It's the same issue in Scala with the Timestamp encoder that uses `DateTimeUtils.fromJavaTimestamp`/`toJavaTimestamp`.
 Fixing these is well beyond the scope of this PR, is it planned to be fixed elsewhere?
    
    Given that this will cause problems with importing/exporting Arrow data, and that is a
big part of the use case for Arrow, what exactly is using `SESSION_LOCAL_TIMEZONE` going to
help with until the above is fixed?  I'm fine with putting in the PR from @ueshin if that
is what everyone prefers, but I just want to understand a little more about the intent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message