spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <...@git.apache.org>
Subject [GitHub] spark pull request #18281: [SPARK-21027][ML][PYTHON] Added tunable paralleli...
Date Fri, 28 Jul 2017 00:21:48 GMT
Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18281#discussion_r129989469
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/HasParallelism.scala ---
    @@ -0,0 +1,56 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.ml.param.shared
    +
    +import scala.concurrent.ExecutionContext
    +
    +import org.apache.spark.ml.param.{IntParam, Params, ParamValidators}
    +import org.apache.spark.util.ThreadUtils
    +
    +/**
    + * Common parameter for estimators trained in a multithreaded environment.
    + */
    +private[ml] trait HasParallelism extends Params {
    +
    +  /**
    +   * param for the number of threads to use when running parallel meta-algorithms
    +   * @group expertParam
    +   */
    +  val parallelism = new IntParam(this, "parallelism",
    +    "the number of threads to use when running parallel algorithms", ParamValidators.gtEq(1))
    +
    +  setDefault(parallelism -> 1)
    +
    +  /** @group expertGetParam */
    +  def getParallelism: Int = $(parallelism)
    +
    +  /** @group expertSetParam */
    +  def setParallelism(value: Int): this.type = {
    --- End diff --
    
    You can remove this now that it is in OneVsRest


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message