spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #18658: [SPARK-20871][SQL] limit logging of Janino code
Date Sun, 23 Jul 2017 05:12:26 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18658#discussion_r128910402
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -1037,25 +1038,27 @@ object CodeGenerator extends Logging {
         ))
         evaluator.setExtendedClass(classOf[GeneratedClass])
     
    -    lazy val formatted = CodeFormatter.format(code)
    -
         logDebug({
           // Only add extra debugging info to byte code when we are going to print the source
code.
           evaluator.setDebuggingInformation(true, true, false)
    -      s"\n$formatted"
    +      s"\n${CodeFormatter.format(code)}"
         })
     
         try {
           evaluator.cook("generated.java", code.body)
           recordCompilationStats(evaluator)
         } catch {
           case e: JaninoRuntimeException =>
    -        val msg = s"failed to compile: $e\n$formatted"
    +        val msg = s"failed to compile: $e"
             logError(msg, e)
    +        val maxLines = new SQLConf().loggingMaxLinesForCodegen
    --- End diff --
    
    -> `SQLConf.get.loggingMaxLinesForCodegen`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message