spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #18651: [SPARK-21383][Core] Fix the YarnAllocator allocat...
Date Fri, 21 Jul 2017 18:18:30 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18651#discussion_r128828035
  
    --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
    @@ -525,9 +534,11 @@ private[yarn] class YarnAllocator(
                   } catch {
                     case NonFatal(e) =>
                       logError(s"Failed to launch executor $executorId on container $containerId",
e)
    -                  // Assigned container should be released immediately to avoid unnecessary
resource
    -                  // occupation.
    +                  // Assigned container should be released immediately
    +                  // to avoid unnecessary resource occupation.
                       amClient.releaseAssignedContainer(containerId)
    +              } finally {
    +                numExecutorsStarting.decrementAndGet()
    --- End diff --
    
    this is "starting" not "running".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message