spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #18388: [SPARK-21175] Reject OpenBlocks when memory short...
Date Thu, 20 Jul 2017 12:44:54 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18388#discussion_r128503793
  
    --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
    @@ -257,4 +257,7 @@ public Properties cryptoConf() {
         return CryptoUtils.toCryptoConf("spark.network.crypto.config.", conf.getAll());
       }
     
    +  public long maxChunksBeingTransferred() {
    +    return conf.getLong("spark.network.shuffle.maxChunksBeingTransferred", Long.MAX_VALUE);
    --- End diff --
    
    I feel there are too many "by default disabled" optimizations, which can't benefit most
of the spark users. I'm ok to leave it disabled for now, but we should definitely revisit
it and think about reasonable default values. also cc @tgravescs @zsxwing 
    
    BTW, please document this config in `configuration.md`
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message