spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinxing64 <...@git.apache.org>
Subject [GitHub] spark pull request #18388: [SPARK-21175] Reject OpenBlocks when memory short...
Date Thu, 20 Jul 2017 12:17:12 GMT
Github user jinxing64 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18388#discussion_r128498015
  
    --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
    @@ -257,4 +257,7 @@ public Properties cryptoConf() {
         return CryptoUtils.toCryptoConf("spark.network.crypto.config.", conf.getAll());
       }
     
    +  public long maxChunksBeingTransferred() {
    +    return conf.getLong("spark.network.shuffle.maxChunksBeingTransferred", Long.MAX_VALUE);
    --- End diff --
    
    It depends on memory config of NodeManager. In our cluster, we will set it to be 3G(memory
overhead for Netty)/1k(size of ChannelOutboundBuffer$Entry)=3000000.
    I think it's ok to leave it MAX_VALUE(by default it's disabled).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message