spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From skonto <...@git.apache.org>
Subject [GitHub] spark pull request #18674: [SPARK-21456][MESOS] Make the driver failover_tim...
Date Wed, 19 Jul 2017 14:13:31 GMT
Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18674#discussion_r128257884
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
---
    @@ -58,9 +58,16 @@ package object config {
     
       private [spark] val DRIVER_LABELS =
         ConfigBuilder("spark.mesos.driver.labels")
    -      .doc("Mesos labels to add to the driver.  Labels are free-form key-value pairs.
 Key-value" +
    +      .doc("Mesos labels to add to the driver.  Labels are free-form key-value pairs.
 Key-value " +
             "pairs should be separated by a colon, and commas used to list more than one."
+
             "Ex. key:value,key2:value2")
           .stringConf
           .createOptional
    +
    +  private [spark] val DRIVER_FAILOVER_TIMEOUT =
    +    ConfigBuilder("spark.mesos.driver.failoverTimeout")
    +      .doc("Amount of time in seconds that the master will wait to hear from the driver,
" +
    +          "during a temporary disconnection, before tearing down all the executors.")
    +      .doubleConf
    +      .createWithDefault(0.0)
    --- End diff --
    
    Zero means infinite time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message