spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ConeyLiu <...@git.apache.org>
Subject [GitHub] spark pull request #18670: [SPARK-21455][CORE]RpcFailure should be call on R...
Date Wed, 19 Jul 2017 01:03:42 GMT
Github user ConeyLiu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18670#discussion_r128132310
  
    --- Diff: core/src/test/scala/org/apache/spark/rpc/RpcEnvSuite.scala ---
    @@ -624,7 +624,9 @@ abstract class RpcEnvSuite extends SparkFunSuite with BeforeAndAfterAll
{
           val e = intercept[SparkException] {
             ThreadUtils.awaitResult(f, 1 seconds)
           }
    -      assert(e.getCause.isInstanceOf[NotSerializableException])
    +      assert(e.getCause.isInstanceOf[RuntimeException])
    --- End diff --
    
    Because we need a `Throwable` meesage called back from server, you can see: [NettyRpcEnv.scala#L205](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala#L205)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message