spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DonnyZone <...@git.apache.org>
Subject [GitHub] spark issue #18656: [SPARK-21441]Incorrect Codegen in SortMergeJoinExec resu...
Date Tue, 18 Jul 2017 10:56:45 GMT
Github user DonnyZone commented on the issue:

    https://github.com/apache/spark/pull/18656
  
    I notice that the CollapseCodegenStages rule will still enable codegen for SortMergeJoinExec
without checking CodegenFallback expressions.
    
    The logic in `insertInputAdapter` seems to skip validating SortMergeJoinExec. 
    
    Actually, I'am not familiar with this part, please correct me if I get something wrong
    
    ```
    private def insertInputAdapter(plan: SparkPlan): SparkPlan = plan match {
        case j @ SortMergeJoinExec(_, _, _, _, left, right) if j.supportCodegen =>
          // The children of SortMergeJoin should do codegen separately.
          j.copy(left = InputAdapter(insertWholeStageCodegen(left)),
            right = InputAdapter(insertWholeStageCodegen(right)))
          ......
    ```
    
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message