spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #18574: [SPARK-21350] [SQL] Fix the error message when th...
Date Mon, 10 Jul 2017 07:24:42 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18574#discussion_r126349469
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
    @@ -112,7 +112,12 @@ class SimpleFunctionRegistry extends FunctionRegistry {
             throw new AnalysisException(s"undefined function $name")
           }
         }
    -    func(children)
    +    try {
    +      func(children)
    +    } catch {
    +      case _: ClassCastException =>
    --- End diff --
    
    This is not executing the function, but just finding the function. Will it trigger ClassCastException
that occurred in a function body of the given UDF? Could you give me an example?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message