spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #18571: [SPARK-21344][SQL] BinaryType comparison does sig...
Date Mon, 10 Jul 2017 04:56:18 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18571#discussion_r126335091
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
    @@ -137,4 +137,22 @@ class OrderingSuite extends SparkFunSuite with ExpressionEvalHelper
{
         // verify that we can support up to 5000 ordering comparisons, which should be sufficient
         GenerateOrdering.generate(Array.fill(5000)(sortOrder))
       }
    +
    +  test("SPARK-21344: BinaryType comparison does signed byte array comparison") {
    +    val b1 = Array[Byte](1)   // 0x01
    +    val b2 = Array[Byte](-1)  // 0xff
    --- End diff --
    
    Thank you for your comment, done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message