spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #18503: [SPARK-21271][SQL] Ensure Unsafe.sizeInBytes is a...
Date Thu, 06 Jul 2017 12:51:30 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18503#discussion_r125889190
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
---
    @@ -350,20 +350,24 @@ private[state] class HDFSBackedStateStoreProvider extends StateStoreProvider
wit
               throw new IOException(
                 s"Error reading delta file $fileToRead of $this: key size cannot be $keySize")
             } else {
    -          val keyRowBuffer = new Array[Byte](keySize)
    +          // If key size in an existing file is not a multiple of 8, round it to multiple
of 8
    +          val keyAllocationSize = ((keySize + 7) / 8) * 8
    +          val keyRowBuffer = new Array[Byte](keyAllocationSize)
    --- End diff --
    
    I think all unsafe rows have the size of a multiple of 8, except `RowBasedKeyValueBatch`
in the previous code. So I'm wondering how the state store can have unsafe rows with wrong
size, does state store use `RowBasedKeyValueBatch`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message