spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #18455: [SPARK-21228][SQL] InSet incorrect handling of st...
Date Thu, 06 Jul 2017 11:38:23 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18455#discussion_r125875628
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
    @@ -274,27 +278,40 @@ case class InSet(child: Expression, hset: Set[Any]) extends UnaryExpression
with
         }
       }
     
    -  def getHSet(): Set[Any] = hset
    +  @transient private[this] lazy val set = child.dataType match {
    +    case _: AtomicType => hset
    +    case _: NullType => hset
    +    case _ =>
    +      // for structs use interpreted ordering to be able to compare UnsafeRows with non-UnsafeRows
    +      TreeSet.empty(TypeUtils.getInterpretedOrdering (child.dataType) ) ++ hset
    --- End diff --
    
    no space near `()` please, `.getInterpretedOrdering(child.dataType))`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message