spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #18425: [SPARK-21217][SQL] Support ColumnVector.Array.to<...
Date Thu, 06 Jul 2017 11:00:53 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18425#discussion_r125869849
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
    @@ -387,6 +449,11 @@ private void throwUnsupportedException(int requiredCapacity, Throwable
cause) {
       public abstract byte getByte(int rowId);
     
       /**
    +   * Gets values from [rowId, rowId + count) to [dst, dst + count)
    --- End diff --
    
    Let's also mention that, it's the caller's responsibility to make sure the given array
has enough space.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message