spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaceklaskowski <...@git.apache.org>
Subject [GitHub] spark issue #18523: [SPARK-21285][ML] VectorAssembler reports the column nam...
Date Wed, 05 Jul 2017 08:38:15 GMT
Github user jaceklaskowski commented on the issue:

    https://github.com/apache/spark/pull/18523
  
    Thanks @facaiy for the changes. I wonder if the code could `collect` all the columns with
incorrect type in one go (rather than reporting issues column by column until a user fixed
all).
    
    Something along the lines:
    
    ```
    val incorrectColumns = inputColNames
      .map { name => (name, schema(name).dataType) }
      .collect {
        case (_, _: NumericType | BooleanType) =>
        case t if t.isInstanceOf[VectorUDT] =>
        case other => other }
    // report issue with incorrectColumns
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message