spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From IngoSchuster <...@git.apache.org>
Subject [GitHub] spark issue #18499: [SPARK-21176][WEB UI] Use a single ProxyServlet to proxy...
Date Wed, 05 Jul 2017 07:01:23 GMT
Github user IngoSchuster commented on the issue:

    https://github.com/apache/spark/pull/18499
  
    You are right, a short moment of confusion - already deleted my comment... 
    ;-)
    Please disregard it
    
    
    Regards,
    Ingo Schuster
    
    Tel: +49-(0)7031-16-5156
    
    IBM Analytics
    ----------------------------------------------------------------------------
    IBM Deutschland Research & Development GmbH / Vorsitzende des 
    Aufsichtsrats: Martina Koederitz
    Geschäftsführung: Dirk Wittkopp
    Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, 
    HRB 243294 
    
    
    
    
    From:   Sean Owen <notifications@github.com>
    To:     apache/spark <spark@noreply.github.com>
    Cc:     IngoSchuster <ingo.schuster@de.ibm.com>, Comment 
    <comment@noreply.github.com>
    Date:   04/07/2017 17:11
    Subject:        Re: [apache/spark] [SPARK-21176][WEB UI] Use a single 
    ProxyServlet to proxy all workers and applications (#18499)
    
    
    
    Surely math.max is correct? or else the value is always 1.
    
    On Tue, Jul 4, 2017 at 3:28 PM IngoSchuster <notifications@github.com>
    wrote:
    
    > Can we pull that also into 2.1.1? The original code in JettyUtils to 
    limit
    > the number of selector threads is actually wrong.
    >
    > Instead of
    > val numSelectors = math.max(1, math.min(8,
    > Runtime.getRuntime().availableProcessors() / 2))
    > it should have been
    > val numSelectors = math.min(1, math.max(8,
    > Runtime.getRuntime().availableProcessors() / 2))
    >
    > With this PR, a fix for the bug above is no longer needed.
    >
    > ?
    > You are receiving this because you are subscribed to this thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/18499#issuecomment-312891651>, or 
    mute
    > the thread
    > <
    https://github.com/notifications/unsubscribe-auth/AAyM-hHnlELpIMQhDoh54FOG1XS5_DxCks5sKkvwgaJpZM4OLSCA
    >
    > .
    >
    ?
    You are receiving this because you commented.
    Reply to this email directly, view it on GitHub, or mute the thread.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message