spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #18493: [SPARK-20889][SparkR][Followup] Clean up grouped ...
Date Tue, 04 Jul 2017 19:36:49 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18493#discussion_r125522977
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -38,9 +38,9 @@ NULL
     #'
     #' Date time functions defined for \code{Column}.
     #'
    -#' @param x Column to compute on.
    -#' @param format For \code{to_date} and \code{to_timestamp}, it is the string to use
to parse
    -#'               x Column to DateType or TimestampType. For \code{trunc}, it is the string
used
    +#' @param x Column to compute on. In \code{window}, it must be a time Column of \code{TimestampType}.
    +#' @param format For \code{to_date} and \code{to_timestamp}, it is the string used to
parse
    --- End diff --
    
    `to use` seems to make sense though?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message