spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #18529: [SPARK-21304][SQL] remove unnecessary isNull vari...
Date Tue, 04 Jul 2017 18:01:14 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18529#discussion_r125516031
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
    @@ -667,7 +672,7 @@ case class MapObjects private(
       }
     }
     
    -object CollectObjectsToMap {
    +object CatalystToExternalMap {
       private val curId = new java.util.concurrent.atomic.AtomicInteger()
     
       /**
    --- End diff --
    
    Could you fix this in documents, too?
    ```
    * Construct an instance of CollectObjectsToMap case class.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message