spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #18416: [SPARK-21204][SQL] Add support for Scala Set coll...
Date Tue, 04 Jul 2017 14:06:45 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18416#discussion_r125481173
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
    @@ -342,6 +342,17 @@ object ScalaReflection extends ScalaReflection {
               mirror.runtimeClass(t.typeSymbol.asClass)
             )
     
    +      // We serialize a `Set` to Catalyst array. When we deserialize a Catalyst array
    +      // to a `Set`, if there are duplicated elements, the elements will be de-duplicated.
    +      case t if t <:< localTypeOf[Set[_]] =>
    +        val TypeRef(_, _, Seq(elementType)) = t
    +
    +        CollectObjectsToSet(
    --- End diff --
    
    yea, I think it's much simpler than introducing 2 new expressions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message