spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark issue #18281: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...
Date Tue, 04 Jul 2017 01:12:17 GMT
Github user BryanCutler commented on the issue:

    https://github.com/apache/spark/pull/18281
  
    > What is the point of having the function getExectionContext() take a parameter maxThreads?
Isn't it just supposed to use the parallelism parameter when determining what execution context
to return?
    
    My only thought with this is that when using `getExecutionContext()` it kind of hides
the fact that your using the `paralllelism` parameter to create the ExecutionContext, where
if you pass it as a parameter, e.g. `getExecutionContext($(parallelism))` it's easy to see
you are using that parameter to make the execution context - no need to drill down to the
trait.
    
    It's not a big deal though, so I thinks this is fine as-is unless others have the same
thought.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message