spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wzhfy <...@git.apache.org>
Subject [GitHub] spark pull request #18504: [TEST] Load test table based on case sensitivity
Date Mon, 03 Jul 2017 13:49:58 GMT
Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18504#discussion_r125293645
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
    @@ -553,7 +555,10 @@ private[hive] class TestHiveQueryExecution(
         val referencedTables =
           describedTables ++
             logical.collect { case UnresolvedRelation(tableIdent, _) => tableIdent.table
}
    -    val referencedTestTables = referencedTables.filter(sparkSession.testTables.contains)
    +    val formattedRefTables = referencedTables.map { t =>
    +      if (sparkSession.sessionState.conf.caseSensitiveAnalysis) t else t.toLowerCase(Locale.ROOT)
    +    }
    +    val referencedTestTables = formattedRefTables.filter(sparkSession.testTables.contains)
    --- End diff --
    
    It would be an `O(N^2)` operation, but since the number of referenced tables should be
small, I think that's ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message