spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #18498: [SPARK-21266][R][PYTHON] Support schema a DDL-for...
Date Sat, 01 Jul 2017 20:56:17 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18498#discussion_r125168993
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -3078,9 +3078,8 @@ object functions {
        * string.
        *
        * @param e a string column containing JSON data.
    -   * @param schema the schema to use when parsing the json string as a json string. In
Spark 2.1,
    -   *               the user-provided schema has to be in JSON format. Since Spark 2.2,
the DDL
    -   *               format is also supported for the schema.
    +   * @param schema the schema to use when parsing the json string as a json string
    +   *               or a DDL-formatted string.
    --- End diff --
    
    (These are strictly not related with this PR but i just decided to pick this up.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message