Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: actuaryzhang <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18114-spark@git.apache.org>
In-Reply-To: <git-pr-18114-spark@git.apache.org>
Subject: [GitHub] spark pull request #18114: [SPARK-20889][SparkR] Grouped documentation for D...
Content-Type: text/plain
Message-Id: <20170621182149.B2367DFBDA@git1-us-west.apache.org>
Date: Wed, 21 Jun 2017 18:21:49 +0000 (UTC)
archived-at: Wed, 21 Jun 2017 18:21:51 -0000

Github user actuaryzhang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18114#discussion_r123327948
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -2348,26 +2336,18 @@ setMethod("n", signature(x = "Column"),
                 count(x)
               })
     
    -#' date_format
    -#'
    -#' Converts a date/timestamp/string to a value of string in the format specified by the date
    -#' format given by the second argument.
    -#'
    -#' A pattern could be for instance \preformatted{dd.MM.yyyy} and could return a string like '18.03.1993'. All
    +#' @section Details:
    +#' \code{date_format}: Converts a date/timestamp/string to a value of string in the format
    +#' specified by the date format given by the second argument. A pattern could be for instance
    +#' \code{dd.MM.yyyy} and could return a string like '18.03.1993'. All
     #' pattern letters of \code{java.text.SimpleDateFormat} can be used.
    -#'
     #' Note: Use when ever possible specialized functions like \code{year}. These benefit from a
     #' specialized implementation.
     #'
    -#' @param y Column to compute on.
    -#' @param x date format specification.
    +#' @rdname column_datetime_diff_functions
     #'
    -#' @family date time functions
    -#' @rdname date_format
    -#' @name date_format
    -#' @aliases date_format,Column,character-method
    +#' @aliases date_format date_format,Column,character-method
     #' @export
    -#' @examples \dontrun{date_format(df$t, 'MM/dd/yyy')}
    --- End diff --
    
    Added back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org