Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: gatorsmile <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18303-spark@git.apache.org>
In-Reply-To: <git-pr-18303-spark@git.apache.org>
Subject: [GitHub] spark pull request #18303: [SPARK-19824][Core] Update JsonProtocol to keep c...
Content-Type: text/plain
Message-Id: <20170618172703.BF709E01C3@git1-us-west.apache.org>
Date: Sun, 18 Jun 2017 17:27:03 +0000 (UTC)
archived-at: Sun, 18 Jun 2017 17:27:05 -0000

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18303#discussion_r122596579
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala ---
    @@ -21,74 +21,192 @@ import org.json4s.JsonAST.JObject
     import org.json4s.JsonDSL._
     
     import org.apache.spark.deploy.DeployMessages.{MasterStateResponse, WorkerStateResponse}
    -import org.apache.spark.deploy.master.{ApplicationInfo, DriverInfo, WorkerInfo}
    +import org.apache.spark.deploy.master._
    +import org.apache.spark.deploy.master.RecoveryState.MasterState
     import org.apache.spark.deploy.worker.ExecutorRunner
     
     private[deploy] object JsonProtocol {
    - def writeWorkerInfo(obj: WorkerInfo): JObject = {
    -   ("id" -> obj.id) ~
    -   ("host" -> obj.host) ~
    -   ("port" -> obj.port) ~
    -   ("webuiaddress" -> obj.webUiAddress) ~
    -   ("cores" -> obj.cores) ~
    -   ("coresused" -> obj.coresUsed) ~
    -   ("coresfree" -> obj.coresFree) ~
    -   ("memory" -> obj.memory) ~
    -   ("memoryused" -> obj.memoryUsed) ~
    -   ("memoryfree" -> obj.memoryFree) ~
    -   ("state" -> obj.state.toString) ~
    -   ("lastheartbeat" -> obj.lastHeartbeat)
    - }
    +  /**
    +   * Export the [[WorkerInfo]] to a Json object, a [[WorkerInfo]] consists of the information of a
    +   * worker.
    +   *
    +   * @return a Json object containing the following fields:
    +   *         `id` a string identifier of the worker
    +   *         `host` the host that the worker is running on
    +   *         `port` the port that the worker is bound to
    +   *         `address` ${host}:${port}
    +   *         `webuiaddress` the address used in web UI
    +   *         `cores` total cores of the worker
    +   *         `coresused` allocated cores of the worker
    +   *         `coresfree` free cores of the worker
    +   *         `memory` total memory of the worker
    +   *         `memoryused` allocated memory of the worker
    +   *         `memoryfree` free memory of the worker
    +   *         `state` state of the worker, see [[WorkerState]]
    +   *         `lastheartbeat` time in milliseconds that the latest heart beat message from the
    +   *         worker is received.
    +   */
    +  def writeWorkerInfo(obj: WorkerInfo): JObject = {
    +    ("id" -> obj.id) ~
    +    ("host" -> obj.host) ~
    +    ("port" -> obj.port) ~
    +    ("address" -> obj.hostPort) ~
    +    ("webuiaddress" -> obj.webUiAddress) ~
    +    ("cores" -> obj.cores) ~
    +    ("coresused" -> obj.coresUsed) ~
    +    ("coresfree" -> obj.coresFree) ~
    +    ("memory" -> obj.memory) ~
    +    ("memoryused" -> obj.memoryUsed) ~
    +    ("memoryfree" -> obj.memoryFree) ~
    +    ("state" -> obj.state.toString) ~
    +    ("lastheartbeat" -> obj.lastHeartbeat)
    +  }
     
    +  /**
    +   * Export the [[ApplicationInfo]] to a Json object, an [[ApplicationInfo]] consists of the
    +   * information of an application.
    +   *
    +   * @return a Json object containing the following fields:
    +   *         `id` a string identifier of the application
    +   *         `starttime` time in milliseconds that the application starts
    +   *         `name` a name describes the application
    +   *         `cores` total cores granted to the application
    +   *         `user` name of the user who submitted the application
    +   *         `memoryperslave` minimal memory in MB required to each executor
    +   *         `submitdate` time in Date that the application is submitted
    +   *         `state` state of the application, see [[ApplicationState]]
    +   *         `duration` time in milliseconds that the application has been running
    +   */
       def writeApplicationInfo(obj: ApplicationInfo): JObject = {
         ("starttime" -> obj.startTime) ~
         ("id" -> obj.id) ~
         ("name" -> obj.desc.name) ~
    -    ("cores" -> obj.desc.maxCores) ~
    +    ("cores" -> obj.coresGranted) ~
         ("user" -> obj.desc.user) ~
         ("memoryperslave" -> obj.desc.memoryPerExecutorMB) ~
         ("submitdate" -> obj.submitDate.toString) ~
         ("state" -> obj.state.toString) ~
         ("duration" -> obj.duration)
       }
     
    +  /**
    +   * Export the [[ApplicationDescription]] to a Json object, an [[ApplicationDescription]] consists
    +   * of the description of an application.
    +   *
    +   * @return a Json object containing the following fields:
    +   *         `name` a name describes the application
    --- End diff --
    
    -> the description of the application


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org