Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: srowen <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18212-spark@git.apache.org>
In-Reply-To: <git-pr-18212-spark@git.apache.org>
Subject: [GitHub] spark pull request #18212: [SPARK-20995][CORE]'Spark-env.sh.template' should...
Content-Type: text/plain
Message-Id: <20170608081038.E753DDFE22@git1-us-west.apache.org>
Date: Thu,  8 Jun 2017 08:10:38 +0000 (UTC)
archived-at: Thu, 08 Jun 2017 08:10:42 -0000

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18212#discussion_r120823962
  
    --- Diff: conf/spark-env.sh.template ---
    @@ -23,6 +23,7 @@
     # Options read when launching programs locally with
     # ./bin/run-example or ./bin/spark-submit
     # - HADOOP_CONF_DIR, to point Spark towards Hadoop configuration files
    +# - YARN_CONF_DIR, to point Spark towards YARN configuration files
    --- End diff --
    
    Sure, but you have added this to the section that doesn't concern YARN. Just remove this line. You added it to the YARN section below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org