spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gengliangwang <...@git.apache.org>
Subject [GitHub] spark pull request #18471: [SPARK-21259] More rules for scalastyle
Date Thu, 29 Jun 2017 23:49:22 GMT
GitHub user gengliangwang opened a pull request:

    https://github.com/apache/spark/pull/18471

    [SPARK-21259] More rules for scalastyle

    ## What changes were proposed in this pull request?
    Add more rules for scalastyle
    
    During code review, we spent so much time on code style issues.
    It would be great if we add rules:
    1) disallow space before colon
    2) disallow space before right parentheses
    3) disallow space after left parentheses
    
    ## How was this patch tested?
    
    unit tests, integration tests
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gengliangwang/spark scalastyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18471.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18471
    
----
commit 3a4eee0a83de1f3830c101a1dfdfa340dba15758
Author: Wang Gengliang <ltnwgl@gmail.com>
Date:   2017-06-29T22:01:17Z

    first run

commit ff6a50a17d9a77049be7642e66c400d9fab87375
Author: Wang Gengliang <ltnwgl@gmail.com>
Date:   2017-06-29T23:20:57Z

    resolve hard ones

commit 6eccd2636e577439d3539eea79068abadd6122dc
Author: Wang Gengliang <ltnwgl@gmail.com>
Date:   2017-06-29T23:24:47Z

    fix one error

commit cb602758437a2cf7752547433de1a85bd36b0037
Author: Wang Gengliang <ltnwgl@gmail.com>
Date:   2017-06-29T23:28:09Z

    resolve more

commit 6329dfb1304f5a1ff3c210a464b1f11b9b3b9760
Author: Wang Gengliang <ltnwgl@gmail.com>
Date:   2017-06-29T23:34:53Z

    more scalastyle off/on

commit f68e60014ca2f1dbb502dbb942e109505c892c5a
Author: Wang Gengliang <ltnwgl@gmail.com>
Date:   2017-06-29T23:36:48Z

    Insert a space after the start of the comment

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message