spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark issue #18471: [SPARK-21259] More rules for scalastyle
Date Fri, 30 Jun 2017 11:25:02 GMT
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/18471
  
    I tend to agree with the style change, but, am concerned about what a huge diff this creates
for little gain. I personally am not sure I'd bother with the colon change; some instances
of space before colon are conventional like `[K : ClassTag]`, although many you fixed should
indeed not have had a space. I also am not sure we want to enforce the naming convention you
suggest here.
    
    The space inside parens change seems OK, maybe smaller.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message