spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #18445: [Spark-19726][SQL] Faild to insert null timestamp...
Date Fri, 30 Jun 2017 06:10:12 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18445#discussion_r124970124
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
    @@ -266,10 +266,14 @@ object JdbcUtils extends Logging {
       /**
        * Takes a [[ResultSet]] and returns its Catalyst schema.
        *
    +   * @param alwaysNullable If true, all the columns are nullable.
        * @return A [[StructType]] giving the Catalyst schema.
        * @throws SQLException if the schema contains an unsupported type.
        */
    -  def getSchema(resultSet: ResultSet, dialect: JdbcDialect): StructType = {
    +  def getSchema(
    +      resultSet: ResultSet,
    +      dialect: JdbcDialect,
    +      alwaysNullable: Boolean = true): StructType = {
    --- End diff --
    
    You should change the value to `true` in the caller side. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message