spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Date Thu, 29 Jun 2017 02:32:10 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9518#discussion_r124689398
  
    --- Diff: core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
    @@ -0,0 +1,167 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.metrics.sink
    +
    +import java.io.IOException
    +import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
    +import java.nio.charset.StandardCharsets.UTF_8
    +import java.util.SortedMap
    +import java.util.concurrent.TimeUnit
    +
    +import scala.collection.JavaConverters._
    +import scala.util.{Failure, Success, Try}
    +
    +import com.codahale.metrics._
    +import org.apache.hadoop.net.NetUtils
    +
    +import org.apache.spark.internal.Logging
    +
    +/**
    + * @see <a href="https://github.com/etsy/statsd/blob/master/docs/metric_types.md">
    + *        StatsD metric types</a>
    + */
    +private[spark] object StatsdMetricType {
    +  val COUNTER = "c"
    +  val GAUGE = "g"
    +  val TIMER = "ms"
    +  val Set = "s"
    +}
    +
    +private[spark] class StatsdReporter(
    +    registry: MetricRegistry,
    +    host: String = "127.0.0.1",
    +    port: Int = 8125,
    +    prefix: String = "",
    +    filter: MetricFilter = MetricFilter.ALL,
    +    rateUnit: TimeUnit = TimeUnit.SECONDS,
    +    durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
    +  extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit, durationUnit)
    +  with Logging {
    +
    +  import StatsdMetricType._
    +
    +  private val address = new InetSocketAddress(host, port)
    +  private val whitespace = "[\\s]+".r
    +
    +  override def report(
    +      gauges: SortedMap[String, Gauge[_]],
    +      counters: SortedMap[String, Counter],
    +      histograms: SortedMap[String, Histogram],
    +      meters: SortedMap[String, Meter],
    +      timers: SortedMap[String, Timer]): Unit =
    +    Try(new DatagramSocket) match {
    +      case Failure(ioe: IOException) => logWarning("StatsD datagram socket construction
failed",
    +        NetUtils.wrapException(host, port, NetUtils.getHostname(), 0, ioe))
    +      case Failure(e) => logWarning("StatsD datagram socket construction failed",
e)
    +      case Success(s) =>
    +        implicit val socket = s
    +        val localAddress = Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
    +        val localPort = socket.getLocalPort
    +        Try {
    +          gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey, e.getValue))
    +          counters.entrySet.asScala.foreach(e => reportCounter(e.getKey, e.getValue))
    +          histograms.entrySet.asScala.foreach(e => reportHistogram(e.getKey, e.getValue))
    +          meters.entrySet.asScala.foreach(e => reportMetered(e.getKey, e.getValue))
    +          timers.entrySet.asScala.foreach(e => reportTimer(e.getKey, e.getValue))
    +        } recover {
    +          case ioe: IOException =>
    +            logDebug(s"Unable to send packets to StatsD", NetUtils.wrapException(
    +              address.getHostString, address.getPort, localAddress, localPort, ioe))
    +          case e: Throwable => logDebug(s"Unable to send packets to StatsD at '$host:$port'",
e)
    +        }
    +        Try(socket.close()) recover {
    +          case ioe: IOException =>
    +            logDebug("Error when close socket to StatsD", NetUtils.wrapException(
    +              address.getHostString, address.getPort, localAddress, localPort, ioe))
    +          case e: Throwable => logDebug("Error when close socket to StatsD", e)
    +        }
    +    }
    +
    +  private def reportGauge(name: String, gauge: Gauge[_])(implicit socket: DatagramSocket)
=
    --- End diff --
    
    Can you please add return type to the method here and below?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message