spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wzhfy <...@git.apache.org>
Subject [GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...
Date Mon, 26 Jun 2017 06:32:19 GMT
Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18323#discussion_r123934820
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/MathUtils.scala
---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.util
    +
    +import org.apache.spark.sql.AnalysisException
    +
    +object MathUtils {
    +
    +  /**
    +   *  Returns the bucket number into which
    +   *  the value of this expression would fall after being evaluated.
    +   *
    +   * @param expr id the expression for which the histogram is being created
    +   * @param minValue is an expression that resolves
    +   *                 to the minimum end point of the acceptable range for expr
    +   * @param maxValue is an expression that resolves
    +   *                 to the maximum end point of the acceptable range for expr
    +   * @param numBucket is an An expression that resolves to
    +   *                  a constant indicating the number of buckets
    +   * @return Returns an long between 0 and numBucket+1 by mapping the expr into buckets
defined by
    +   *         the range [minValue, maxValue]. For example:
    +   *         widthBucket(0, 1, 1, 1) -> 0, widthBucket(20, 1, 1, 1) -> 2.
    +   */
    +  def widthBucket(expr: Double, minValue: Double, maxValue: Double, numBucket: Long):
Long = {
    +
    +    if (numBucket <= 0) {
    +      throw new AnalysisException(s"The num of bucket must be greater than 0, but got
${numBucket}")
    +    }
    --- End diff --
    
    I know, but my question is: should the possible result when minValue == maxValue only
be 0, 1, or 2? e.g. should `width_bucket(2, 1, 1, 100) = 101 or just throw an error for invalid
input?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message