spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #18106: [SPARK-20754][SQL] Support TRUNC (number)
Date Fri, 23 Jun 2017 14:18:42 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18106#discussion_r123758795
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
    @@ -132,3 +133,154 @@ case class Uuid() extends LeafExpression {
           s"UTF8String.fromString(java.util.UUID.randomUUID().toString());", isNull = "false")
       }
     }
    +
    +/**
    + * Returns date truncated to the unit specified by the format or
    + * numeric truncated to scale decimal places.
    + */
    +// scalastyle:off line.size.limit
    +@ExpressionDescription(
    +  usage = """
    +      _FUNC_(data[, fmt]) - Returns `data` truncated by the format model `fmt`.
    +        If `data` is DateType, returns `data` with the time portion of the day truncated
to the unit specified by the format model `fmt`.
    +        If `data` is DecimalType/DoubleType, returns `data` truncated to `fmt` decimal
places.
    +  """,
    +  extended = """
    +    Examples:
    +      > SELECT _FUNC_('2009-02-12', 'MM');
    --- End diff --
    
    And I don't think we should drop this support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message