spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #18114: [SPARK-20889][SparkR] Grouped documentation for D...
Date Wed, 21 Jun 2017 17:28:01 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18114#discussion_r123310134
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -2774,27 +2724,16 @@ setMethod("format_string", signature(format = "character", x =
"Column"),
                 column(jc)
               })
     
    -#' from_unixtime
    -#'
    -#' Converts the number of seconds from unix epoch (1970-01-01 00:00:00 UTC) to a string
    -#' representing the timestamp of that moment in the current system time zone in the given
    -#' format.
    +#' @section Details:
    +#' \code{from_unixtime}: Converts the number of seconds from unix epoch (1970-01-01 00:00:00
UTC) to a
    +#' string representing the timestamp of that moment in the current system time zone in
the given format.
    --- End diff --
    
    I think we need to call out that "current system time zone" is the one in JVM - in R one
could set the default TZ


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message