spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pralabhkumar <...@git.apache.org>
Subject [GitHub] spark pull request #18118: [SPARK-20199][ML] : Provided featureSubsetStrateg...
Date Wed, 21 Jun 2017 14:43:43 GMT
Github user pralabhkumar commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18118#discussion_r123269246
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
    @@ -359,38 +365,6 @@ private[ml] trait TreeEnsembleParams extends DecisionTreeParams {
           oldImpurity: OldImpurity): OldStrategy = {
         super.getOldStrategy(categoricalFeatures, numClasses, oldAlgo, oldImpurity, getSubsamplingRate)
       }
    -}
    -
    -/**
    - * Parameters for Random Forest algorithms.
    - */
    -private[ml] trait RandomForestParams extends TreeEnsembleParams {
    --- End diff --
    
    @MLnick 
     
    Earlier featureSubsetStrategy, setFeatureSubsetStrategy, getFeatureSubsetStrategy were
part of RandomForestParams , moved them to be part of TreeEnsembleParams , so that it can
be accessed by both Random forest and GBT . I have not moved anything apart from that . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message