spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbasmanova <...@git.apache.org>
Subject [GitHub] spark pull request #18309: [SPARK-21079] [SQL] Calculate total size of a par...
Date Wed, 21 Jun 2017 13:07:45 GMT
Github user mbasmanova commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18309#discussion_r123242117
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
    @@ -128,6 +129,45 @@ class StatisticsSuite extends StatisticsCollectionTestBase with TestHiveSingleto
           TableIdentifier("tempTable"), ignoreIfNotExists = true, purge = false)
       }
     
    +  test("SPARK-21079 - analyze table with location different than that of individual partitions")
{
    +    def queryTotalSize(tableName: String): BigInt =
    +      spark.table(tableName).queryExecution.analyzed.stats(conf).sizeInBytes
    +
    +    val tableName = "analyzeTable_part"
    +    withTable(tableName) {
    +      withTempPaths(4) {
    +        case tablePath :: partitionPaths =>
    +          sql(
    +            s"""
    +               |CREATE TABLE ${tableName} (key STRING, value STRING) PARTITIONED BY (ds
STRING)
    +               |LOCATION '${tablePath}'
    +             """.
    +              stripMargin).collect()
    +
    +          val partitionDates = List("2010-01-01", "2010-01-02", "2010-01-03")
    +          partitionDates.zip(partitionPaths).foreach {
    +            case (ds, path) =>
    +              sql(
    +                s"""
    +                   |ALTER TABLE ${tableName} ADD PARTITION (ds='${ds}')
    +                   |LOCATION '${path.toString}'
    +                """.
    +                  stripMargin).collect()
    +              sql(
    +                s"""
    +                   |INSERT INTO TABLE ${tableName} PARTITION (ds='${ds}')
    +                   |SELECT * FROM src
    +                """.
    +                  stripMargin).collect()
    +          }
    +
    +          sql(s"ANALYZE TABLE ${tableName} COMPUTE STATISTICS noscan")
    +
    +          assert(queryTotalSize(tableName) === BigInt(17436))
    --- End diff --
    
    Ok. I'll simplify the test and remove withTempPaths function. Since I need to make sure
that partition locations are not under table location, I'll include ALTER TABLE $tableName
SET LOCATION '$path' after creating table with partitions in the default location. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message