spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request #18322: [SPARK-21115][Core]If the cores left is less than...
Date Tue, 20 Jun 2017 09:38:53 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18322#discussion_r122927162
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -543,6 +543,30 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging
with Seria
           }
         }
     
    +    if (contains("spark.cores.max")) {
    +      val totalCores = getInt("spark.cores.max", -1)
    --- End diff --
    
    Sorry my fault, I misunderstood the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message