spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shivaram <...@git.apache.org>
Subject [GitHub] spark pull request #18320: [SPARK-21093][R] Terminate R's worker processes i...
Date Mon, 19 Jun 2017 19:46:19 GMT
Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18320#discussion_r122803981
  
    --- Diff: R/pkg/inst/worker/daemon.R ---
    @@ -31,7 +31,15 @@ inputCon <- socketConnection(
         port = port, open = "rb", blocking = TRUE, timeout = connectionTimeout)
     
     while (TRUE) {
    -  ready <- socketSelect(list(inputCon))
    +  ready <- socketSelect(list(inputCon), timeout = 1)
    --- End diff --
    
    @HyukjinKwon Do we know what the old behavior was doing ? I'm thinking if we would spend
more time in the loop below now and be less responsive to the `inputCon`. One thing -- Can
we control the timeout based on whether there are any children running or not ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message