spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #18338: [SPARK-21129] [SQL] Arguments of SQL function cal...
Date Sun, 18 Jun 2017 08:33:40 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18338#discussion_r122585242
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
    @@ -231,7 +231,6 @@ class ExpressionParserSuite extends PlanTest {
         assertEqual("foo(distinct a, b)", 'foo.distinctFunction('a, 'b))
         assertEqual("grouping(distinct a, b)", 'grouping.distinctFunction('a, 'b))
         assertEqual("`select`(all a, b)", 'select.function('a, 'b))
    -    assertEqual("foo(a as x, b as e)", 'foo.function('a as 'x, 'b as 'e))
    --- End diff --
    
    Hi, @gatorsmile .
    Could you add the following instead?
    ```scala
    intercept("foo(a x)", "extraneous input 'x'")
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message