spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From actuaryzhang <...@git.apache.org>
Subject [GitHub] spark pull request #18025: [SPARK-20889][SparkR] Grouped documentation for A...
Date Fri, 16 Jun 2017 03:42:50 GMT
Github user actuaryzhang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18025#discussion_r122358689
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -919,10 +920,9 @@ setGeneric("array_contains", function(x, value) { standardGeneric("array_contain
     #' @export
     setGeneric("ascii", function(x) { standardGeneric("ascii") })
     
    -#' @param x Column to compute on or a GroupedData object.
    --- End diff --
    
    In this case, we will have to document `avg` on its own, like `count`, `first` and `last`.
I cannot document the `x` param here since it will show up in the  doc for the column class.
Interestingly, there is not even a doc of the `avg` method from the `GroupedData` class....



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message