spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #18025: [SPARK-20889][SparkR] Grouped documentation for A...
Date Thu, 15 Jun 2017 07:20:13 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18025#discussion_r122133805
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -1403,20 +1416,25 @@ setGeneric("unix_timestamp", function(x, format) { standardGeneric("unix_timesta
     #' @export
     setGeneric("upper", function(x) { standardGeneric("upper") })
     
    -#' @rdname var
    +#' @rdname column_aggregate_functions
    +#' @param y,na.rm,use currently not used.
    --- End diff --
    
    hmm, this is in `var` but also in `sd` too - perhaps should move to column_aggregate_functions
    
    in fact, in your screen shot they are both listed https://github.com/apache/spark/pull/18025#issuecomment-303877945
    `y,na.rm,use` and then `na.rm`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message