spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <>
Subject [GitHub] spark pull request #18301: [SPARK-21052][SQL] Add hash map metrics to join
Date Thu, 15 Jun 2017 03:52:23 GMT
Github user viirya commented on a diff in the pull request:
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
    @@ -573,8 +586,11 @@ private[execution] final class LongToUnsafeRowMap(val mm: TaskMemoryManager,
       private def updateIndex(key: Long, address: Long): Unit = {
         var pos = firstSlot(key)
         assert(numKeys < array.length / 2)
    +    numKeyLookups += 1
    --- End diff --
    Should we? It seems to me that we should only care about the hash collision happened when
inserting the data into the hash map.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message