spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #17865: [SPARK-20456][Docs] Add examples for functions co...
Date Mon, 12 Jun 2017 22:38:12 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17865#discussion_r121539157
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -189,15 +210,15 @@ def _():
     }
     
     for _name, _doc in _functions.items():
    -    globals()[_name] = since(1.3)(_create_function(_name, _doc))
    +    globals()[_name] = since(1.3)(ignore_unicode_prefix(_create_function(_name, _doc)))
     for _name, _doc in _functions_1_4.items():
         globals()[_name] = since(1.4)(_create_function(_name, _doc))
     for _name, _doc in _binary_mathfunctions.items():
         globals()[_name] = since(1.4)(_create_binary_mathfunction(_name, _doc))
     for _name, _doc in _window_functions.items():
         globals()[_name] = since(1.6)(_create_window_function(_name, _doc))
     for _name, _doc in _functions_1_6.items():
    -    globals()[_name] = since(1.6)(_create_function(_name, _doc))
    +    globals()[_name] = since(1.6)(ignore_unicode_prefix(_create_function(_name, _doc)))
    --- End diff --
    
    This one looks also the same instance. Let's avoid adding unicode examples in `_collect_list_doc`
and `_collect_set_doc` for now if we are all fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message